Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JarInfer does not run on JDK 21 #829

Closed
msridhar opened this issue Sep 5, 2023 · 0 comments · Fixed by #887
Closed

JarInfer does not run on JDK 21 #829

msridhar opened this issue Sep 5, 2023 · 0 comments · Fixed by #887

Comments

@msridhar
Copy link
Collaborator

msridhar commented Sep 5, 2023

This is because WALA does not yet work on JDK 21, see wala/WALA#1318. Once WALA is updated, we should update and run JarInfer tests on JDK 21.
@msridhar msridhar mentioned this issue Sep 5, 2023
Merged
msridhar added a commit that referenced this issue Sep 5, 2023
@msridhar
Run tests on JDK 21 (#826)
f98bc4b 
It looks like most of our tests pass on JDK 21. Exceptions are the
JSpecify generics tests, which rely on an API that changed in JDK 21
(see #827), and the JarInfer tests, as it looks like WALA does not yet
support running on JDK 21 (see #829). Core NullAway support (ignoring
the experimental/WIP JSpecify mode) should be working. This PR adds test
configs so that we run tests on JDK 21 wherever possible. We update our
Jacoco and Mockito versions to make this work.

We also take the opportunity to move some common test configuration code
to the `nullaway.java-test-conventions.gradle` file, which previously
just held configuration for Jacoco.
@msridhar msridhar mentioned this issue Jan 3, 2024
Merged
msridhar added a commit that referenced this issue Jan 3, 2024
@msridhar
Update to WALA 1.6.3 (#887)
b5cd1f9 
Fixes #829 

WALA 1.6.3 supports running on JDK 21, so JarInfer now runs on JDK 21
and the tests pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to WALA 1.6.3 msridhar/NullAway
1 participant
@msridhar