Add support for renamed android.support packages in models. #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See. https://developer.android.com/jetpack/androidx/migrate We are adding both versions to our default library models to support codebases that have and haven't migrated.
|
I believe this the only change needed. Since test cases only need to be upgraded once we switch their version of the support library, and everywhere else NullAway just looks for any |
kageiit
approved these changes
Nov 8, 2018
msridhar
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See. https://developer.android.com/jetpack/androidx/migrate
We are adding both versions to our default library models to
support codebases that have and haven't migrated.