Adding support for Activity and Fragment coming from the support libraries: #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fragment and Activity classes that are coming from the support library and Android X * onCreateView and onAttach for the Fragment
|
|
yanislavm
changed the title
|
This change looks great, thanks! Is there any way to add a test though? TBH I'm not sure about our existing coverage of these built-in initializers, but it'd be good to get a test going now at least for the new ones. |
yanislavm
force-pushed
the
feature/support-for-different-initializers-for-android
branch
from
4a71c49
to
9b3f7ab
Compare
msridhar
requested changes
Dec 22, 2018
...test/resources/com/uber/nullaway/testdata/android-error/AndroidxFragmentWithoutOnAttach.java
Outdated
Show resolved
Hide resolved
nullaway/src/test/java/com/uber/nullaway/NullAwayAndroidTest.java
Outdated
Show resolved
Hide resolved
…t error in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to NullAway!
Please note that once you click "Create Pull Request" you will be asked to sign our Uber Contributor License Agreement via CLA assistant.
Before pressing the "Create Pull Request" button, please provide the following:
A description about what and why you are contributing, even if it's trivial.
I noticed that NullAway is not recognising the onCreate method of the Activities and Fragments that are coming from the android support library (and AnddroidX library).
Also for the Fragment it makes sense to support and onCreateView as well as onAttach as those are also like an entry point for the Fragment - in OnCreate we are creating the View and initialising the viewElements.
The issue number(s) or PR number(s) in the description if you are contributing in response to those.
If applicable, unit tests.