Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JSpecify 0.3.0-alpha-1 #673

Merged
merged 6 commits into from
Nov 14, 2022
Merged

Update to JSpecify 0.3.0-alpha-1 #673

merged 6 commits into from
Nov 14, 2022

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Oct 8, 2022

The artifact now contains @NullMarked and @NullUnmarked annotations, so we do not need to create our own for testing.

@coveralls
Copy link

coveralls commented Oct 8, 2022

Pull Request Test Coverage Report for Build #999

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 92.869%

Files with Coverage Reduction New Missed Lines %
../nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPath.java 2 95.77%
Totals Coverage Status
Change from base Build #998: -0.04%
Covered Lines: 5079
Relevant Lines: 5469

💛 - Coveralls

@lazaroclapp
Copy link
Collaborator

Upstream @Null[Un]Marked annotations have ElementKind.MODULE scope, which is not compatible with JDK8. We might not be able to make this change until we deprecate Java 8 support...

@msridhar
Copy link
Collaborator Author

msridhar commented Oct 8, 2022

Upstream @Null[Un]Marked annotations have ElementKind.MODULE scope, which is not compatible with JDK8. We might not be able to make this change until we deprecate Java 8 support...

You're right. I filed jspecify/jspecify#302 just to check if this was intended behavior.

@msridhar msridhar marked this pull request as draft October 9, 2022 18:53
@msridhar msridhar marked this pull request as ready for review November 9, 2022 20:13
@msridhar
Copy link
Collaborator Author

msridhar commented Nov 9, 2022

@lazaroclapp we can work around the JDK 8 javac issue by using Error Prone javac when building on JDK 8. So I think this is ready for review.

"-Xlint:deprecation",
"-Xlint:rawtypes",
"-Xlint:unchecked",
"-Werror"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this since we can't compile with -Werror on JDK 8 anymore (due to warnings caused by jspecify annotations)

Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msridhar msridhar merged commit 3da177a into master Nov 14, 2022
@msridhar msridhar deleted the update-jspecify branch November 14, 2022 19:31
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants