-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JSpecify 0.3.0-alpha-1 #673
Conversation
Pull Request Test Coverage Report for Build #999
💛 - Coveralls |
Upstream |
You're right. I filed jspecify/jspecify#302 just to check if this was intended behavior. |
@lazaroclapp we can work around the JDK 8 javac issue by using Error Prone javac when building on JDK 8. So I think this is ready for review. |
"-Xlint:deprecation", | ||
"-Xlint:rawtypes", | ||
"-Xlint:unchecked", | ||
"-Werror" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving this since we can't compile with -Werror on JDK 8 anymore (due to warnings caused by jspecify annotations)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This reverts commit 3da177a.
The artifact now contains
@NullMarked
and@NullUnmarked
annotations, so we do not need to create our own for testing.