Fix CI on Windows #759
Merged
Fix CI on Windows #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #1086
💛 - Coveralls |
lazaroclapp
approved these changes
Apr 27, 2023
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 18, 2023
This reverts commit f585e23.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 18, 2023
This reverts commit f585e23.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit f585e23.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit f585e23.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit f585e23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like JDK 17 is no longer pre-installed on Windows. Even though we don't run our tests on JDK 17 on Windows, we need it to be available, as it gets used via Gradle toolchains for certain build steps. With this change, we unconditionally install JDK 17 on Windows.