Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Java 8 support #961

Merged
merged 8 commits into from
May 31, 2024
Merged

Drop Java 8 support #961

merged 8 commits into from
May 31, 2024

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented May 29, 2024

This PR drops support for running NullAway on a JDK 8 JVM. After it lands, running NullAway will require JDK 11 or above (like current versions of Error Prone). There are various cleanups that this change enables, but to keep the PR small, I tried to do close to the minimum. In particular:

  • I updated the minimum supported Error Prone version to 2.14.0, which is ~2 years old. Depending on what we decide about policy (see Develop a policy for how long we support Error Prone versions #882) we may want to bump this to an even more recent version.
  • Update our JDK 8 test tasks to instead just test building with the most recent supported Error Prone version but running on the oldest supported version. I tested locally that this does still detect binary compatibility issues.
  • Remove references to Java 11 in the jarinfer build files, as we now use that version everywhere.

We will have to change the required CI job names before landing this.

Will do other enabled cleanups in separate PRs.

@msridhar msridhar changed the title [WIP] Drop Java 8 support Drop Java 8 support May 30, 2024
@msridhar msridhar marked this pull request as ready for review May 30, 2024 22:37
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.11%. Comparing base (5d3e264) to head (21b8999).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #961      +/-   ##
============================================
- Coverage     86.12%   86.11%   -0.01%     
  Complexity     2040     2040              
============================================
  Files            81       81              
  Lines          6708     6707       -1     
  Branches       1293     1293              
============================================
- Hits           5777     5776       -1     
  Misses          518      518              
  Partials        413      413              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar enabled auto-merge (squash) May 31, 2024 14:43
@msridhar msridhar merged commit 2f9bd83 into uber:master May 31, 2024
11 of 12 checks passed
@msridhar msridhar deleted the drop-java-8-support branch May 31, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants