The Initial CacheRedis

[dfellis]

cc @squamos @Raynos @jcorbin

[Raynos]

this.emit('error', err)

[dfellis]

Turn this into an EventEmitter for a single event?

[Raynos]

you also need to re emit errors from redisClient.

[twolfson]

One of these finally. I would always point to EventVat and be sad it never had a callback system for easy swapping =(

https://github.com/hij1nx/EventVat

[dfellis]

@twolfson This library needs to be API-compatible with this one. The API is "inspired" by ES6 Maps, but deviating in that it's async (with *Local methods if you want speed but don't care about cache correctness).

In this case, redis is being used as a shared cache between many workers across servers, so the original temp directory file cache won't do.

[Raynos]

want to remove this print

[dfellis]

yes

[jcorbin]

catch exception / callback error?

[Raynos]

Other then the print and the callback(null, bool) this seems good.

[jcorbin]

Should we emit a ready event after all keys are loaded in the eager case, and right away in the lazy case?

[dfellis]

Sure.

[Raynos]

This looks good to me now.