Server side feature flags #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature flags json.
just-at-uber
commented
Jul 16, 2020
…istory api call mock.
ajbogh
approved these changes
Jul 16, 2020
Merged
just-at-uber
added a commit
that referenced
this pull request
Jul 20, 2020
* Feature/tasklist partition (#166) * moving tasklist into separate folder. adding partition page and navigation tabs * alphabetizing tchannel client api. added listTaskListPartition and hooked up route. Adding front end api call. Need more context to proceed. * finished task list partition screen * adding metrics page. making feature flag style display inline. * 3.18.0-beta.0 * fixing things for PR * lint * fixing test * fix for event which should not be a span but a point. (#167) * 3.18.0-beta.1 * Feature/domain metrics (#169) * adding blank metrics page for domain. * lint fixes * 3.18.0-beta.2 * changing from route variables to props. Fixing props for metrics screen. (#170) * 3.18.0-beta.3 * 3.18.0-beta.4 * Server side feature flags (#171) * updated code to work with server side feature flags instead of using feature flags json. * fixing tests * abstracting common helper out of service. * 3.18.0-beta.5 * allowing endpoint to call next middleware * 3.18.0-beta.6 * PR comments * fixing failing tests * reverting change as it destabilizes test on CI * updating fetch-mock package to latest. adding delay for fullWorkflowHistory api call mock. * lowering fetch-mock package version to see if increases stability. * adding release notes for cadence server go and ui. (#172) * 3.18.0
just-at-uber
pushed a commit
that referenced
this pull request
Jan 8, 2021
* Refactor workflow list for reusability
just-at-uber
added a commit
that referenced
this pull request
Jan 27, 2021
* Refactor workflows list page (#171) * Refactor workflow list for reusability * Add workflows view showing all workflows (#173) * Fix workflows view console error for empty result (#186) * Avoid possible duplication of workflow instance in ALL view (#187) * Fix workflows all view (#208) * Fix workflows ALL view showing empty space (#239) * Fix workflows date range filter dropping out running workflows (#240) * Adjust workflows view spacing (#241) * fix lint & attribute temporal * adding back in default range * Show open worfklows first in All view (#243) * fixing lint * attributing temporal * fixing bugs * fixed bug with change status * fixed issue with overlapping scrollbars * fixing bug where fetch was calling with empty next page token * fixing alt colours in list. sync initial calls incase of race conditions. fixing lint * rename workflow-grid. Fixed integration tests. Fixed bug where range was not being set correctly from URL. * fix lint * rename onScroll * adjust ordering Co-authored-by: Ruslan <11838981+feedmeapples@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow feature flags to be processed by an API endpoint rather than directly serving a JSON file. This gives flexibility as you can override the API endpoint to use a feature flag service integration instead of using a flat JSON configuration.
The only thing to note here is the feature flag names have slightly changed by removing
-from names and are now camel cased.Also
feature-flags.jsonhas now moved into the server folder instead of client folder.isFeatureFlagEnabledhelper has now been removed as it is no longer required (replaced byFeatureFlagService. isFeatureFlagEnabled).