Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set expiresIn when self-signing JWT token #538

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Set expiresIn when self-signing JWT token #538

merged 2 commits into from
Mar 3, 2024

Conversation

mantas-sidlauskas
Copy link
Contributor

Adding standard exp field, but keeping ttl for backwards compatibility.

@Assem-Uber
Copy link
Contributor

Assem-Uber commented Feb 19, 2024 •
edited
Loading

@mantas-sidlauskas thanks for opening the PR,
Checking with peers the reason behind adding ttl in the payload and not just as Expiration time for the token itself

@Assem-Uber Assem-Uber merged commit 470d253 into uber:master Mar 3, 2024
4 checks passed
@Assem-Hafez Assem-Hafez mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mantas-sidlauskas @Assem-Uber @davidporter-id-au