Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update thrift #58

Merged
merged 3 commits into from
Sep 3, 2019
Merged

update thrift #58

merged 3 commits into from
Sep 3, 2019

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Aug 29, 2019

update thrift with UpsertWorkflowSearchAttributes

longquanzheng
longquanzheng approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you test it when rolling out

@yux0
Copy link
Contributor Author

yux0 commented Aug 31, 2019

Verified this change in local. Anyone who has write permission can land this change.

@dmetzgar dmetzgar merged commit f7a5b38 into uber:master Sep 3, 2019
@yux0 yux0 mentioned this pull request Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longquanzheng longquanzheng longquanzheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yux0 @longquanzheng @dmetzgar