Skip to content

Commit

Permalink
fix metric scope location
Browse files Browse the repository at this point in the history
  • Loading branch information
Groxx committed Jun 19, 2024
1 parent f472646 commit 2a3b361
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions common/metrics/defs.go
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,10 @@ const (
GetAvailableIsolationGroupsScope
// TaskValidatorScope is the metric for the taskvalidator's workflow check operation.
TaskValidatorScope

// FrontendGlobalRatelimiter is the metrics scope for frontend.GlobalRatelimiter
FrontendGlobalRatelimiter

NumCommonScopes
)

Expand Down Expand Up @@ -1008,8 +1012,6 @@ const (
FrontendGetSearchAttributesScope
// FrontendGetClusterInfoScope is the metric scope for frontend.GetClusterInfo
FrontendGetClusterInfoScope
// FrontendGlobalRatelimiter is the metrics scope for frontend.GlobalRatelimiter
FrontendGlobalRatelimiter

NumFrontendScopes
)
Expand Down Expand Up @@ -1725,10 +1727,13 @@ var ScopeDefs = map[ServiceIdx]map[int]scopeDefinition{
DomainReplicationQueueScope: {operation: "DomainReplicationQueue"},
ClusterMetadataScope: {operation: "ClusterMetadata"},
HashringScope: {operation: "Hashring"},

// currently used by both frontend and history, but may grow to other limiting-host-services.
FrontendGlobalRatelimiter: {operation: "GlobalRatelimiter"},
},
// Frontend Scope Names
Frontend: {
// Admin API scope co-locates with with frontend
// Admin API scope co-locates with frontend
AdminRemoveTaskScope: {operation: "AdminRemoveTask"},
AdminCloseShardScope: {operation: "AdminCloseShard"},
AdminResetQueueScope: {operation: "AdminResetQueue"},
Expand Down Expand Up @@ -1809,7 +1814,6 @@ var ScopeDefs = map[ServiceIdx]map[int]scopeDefinition{
FrontendResetStickyTaskListScope: {operation: "ResetStickyTaskList"},
FrontendGetSearchAttributesScope: {operation: "GetSearchAttributes"},
FrontendGetClusterInfoScope: {operation: "GetClusterInfo"},
FrontendGlobalRatelimiter: {operation: "GlobalRatelimiter"},
},
// History Scope Names
History: {
Expand Down

0 comments on commit 2a3b361

Please sign in to comment.