Adding support for long retention to sampled workflows #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmetzgar
approved these changes
Sep 25, 2018
samarabbas
reviewed
Sep 25, 2018
common/cache/domainCache.go
Outdated
| func (entry *DomainCacheEntry) GetRetentionDays(workflowID string) int32 { | ||
| if sampledRetentionValue, ok := entry.info.Data[SampleRetentionKey]; ok { | ||
| sampledRetentionDays, err := strconv.Atoi(sampledRetentionValue) | ||
| if err != nil && sampledRetentionDays < int(entry.config.Retention) { |
There was a problem hiding this comment.
Looks like a logic bug. Replace with ||
samarabbas
reviewed
Sep 25, 2018
common/cache/domainCache.go
Outdated
| h.Write([]byte(workflowID)) | ||
| hash := h.Sum32() | ||
|
|
||
| r := float64(hash%1000) / float64(1000) |
There was a problem hiding this comment.
Can you put a comment on explaining the math.
samarabbas
approved these changes
Sep 25, 2018
yiminc-zz
force-pushed
the
sampled_retention
branch
from
7765a8e
to
dbce13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for sampled retentions.