Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for history handler #6007

Merged
merged 4 commits into from
May 10, 2024
Merged

Conversation

timl3136
Copy link
Contributor

What changed?
Added unit tests for replicationMessage methods in history handler

Why?
Improve test coverage and stability

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.64%. Comparing base (ed0a31b) to head (9ea4d3b).
Report is 3 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
common/resource/resourceTest.go 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0a31b...9ea4d3b. Read the comment docs.

@timl3136 timl3136 merged commit dbfb1c8 into uber:master May 10, 2024
20 checks passed
abhishekj720 pushed a commit to abhishekj720/cadence that referenced this pull request May 13, 2024
* Added unit tests for history handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants