Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sanity check for strong idempotency check #6031

Merged
merged 1 commit into from
May 21, 2024

Conversation

Shaddoll
Copy link
Contributor

What changed?

  • Enable sanity check for strong idempotency check
  • Add a dynamicconfig to enable/disable sanity check

Why?

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link
Contributor

@taylanisikdemir taylanisikdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments

service/history/execution/context.go Outdated Show resolved Hide resolved
service/history/execution/context.go Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f9c1a-8018-4148-b5a3-b24b27164e76

Details

  • 29 of 44 (65.91%) changed or added relevant lines in 2 files are covered.
  • 54 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.007%) to 69.189%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/execution/context.go 27 42 64.29%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/matching/tasklist/db.go 2 73.23%
common/task/fifo_task_scheduler.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.72%
common/membership/hashring.go 2 84.69%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.46%
service/history/queue/timer_queue_processor_base.go 4 77.66%
common/persistence/nosql/nosql_task_store.go 5 61.95%
Totals Coverage Status
Change from base Build 018f9b8a-83c7-42c9-9803-e6c804146712: -0.007%
Covered Lines: 101856
Relevant Lines: 147214

💛 - Coveralls

@Shaddoll Shaddoll merged commit bbe87aa into uber:master May 21, 2024
18 checks passed
@Shaddoll Shaddoll deleted the idempotency branch May 21, 2024 17:44
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants