Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Adam optimization optional and learning rate/epochs configurable in DragonNet #604

Merged
merged 1 commit into from Mar 18, 2023

Conversation

jeongyoonlee
Copy link
Collaborator

Proposed changes

This PR fixes #600. As @matthewvowels1 proposed, it makes the Adam optimization step optional and learning_rate and epochs configurable for both Adam and SGD in DragonNet.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@jeongyoonlee
Copy link
Collaborator Author

Currently, CI fails due to the dependency issue between numba and latest numpy (ref: numba/numba#8718).

I tested this PR with numba==0.55.2, numpy==1.22.4, shap==0.41.0 and all 79 unit tests as well as the DragonNet example notebook finished successfully.

Copy link
Collaborator

@paullo0106 paullo0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeongyoonlee jeongyoonlee merged commit ffcf59e into master Mar 18, 2023
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem in dragonnet.py
2 participants