Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder notebook #674

Closed
wants to merge 1 commit into from
Closed

reorder notebook #674

wants to merge 1 commit into from

Conversation

vincewu51
Copy link
Collaborator

Proposed changes

This is to solve issue664.

  1. Re-ordered all notebooks based on submission time.
  2. Re-run all notebooks to make sure they work and make minor changes. (except for 014, which results in kernel dying in my local. I'll start another PR to solve the issue).

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@vincewu51 vincewu51 linked an issue Aug 28, 2023 that may be closed by this pull request
@jeongyoonlee
Copy link
Collaborator

@vincewu51, this PR has different SHAs for previous commits, which conflicts with the master's commits. To get a clean rebase, you can use commands as follows:

git checkout master
git pull
git checkout [your branch]
git rebase origin/master
git push origin [your branch] --force

@vincewu51
Copy link
Collaborator Author

@vincewu51, this PR has different SHAs for previous commits, which conflicts with the master's commits. To get a clean rebase, you can use commands as follows:

git checkout master
git pull
git checkout [your branch]
git rebase origin/master
git push origin [your branch] --force

Thanks @jeongyoonlee, I rebased following the commandas.

@jeongyoonlee
Copy link
Collaborator

jeongyoonlee commented Aug 28, 2023

The order of the notebooks might change later, and adding indices to the file names might lead to the renaming of the multiple notebook files later.

Instead, I think it's better to update docs/examples.rst and README.mds Quick Start section to provide guides to go through example notebooks.

@vincewu51
Copy link
Collaborator Author

Ok, I'll remove the indices and add guidance in the document instead.

@vincewu51
Copy link
Collaborator Author

The conflict is complicated to resolve after 697 and others. It's safer to for me to open a new PR. I'll close this one.

@vincewu51 vincewu51 closed this Nov 17, 2023
@vincewu51 vincewu51 deleted the issue664 branch November 17, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider ordering of examples for new users
2 participants