Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.12 from the build tests in python-test.yaml #726

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

jeongyoonlee
Copy link
Collaborator

Proposed changes

Python 3.12 is not supported by Torch yet and it currently breaks the builds. I've rerun tests for 3.7 through 3.11 and all succeeded.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

Python 3.12 is not supported by Torch yet and it breaks the builds.
@vincewu51 vincewu51 merged commit aa1bc90 into master Dec 8, 2023
14 checks passed
@jeongyoonlee jeongyoonlee deleted the jeong/remove_3_12 branch December 8, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants