-
Notifications
You must be signed in to change notification settings - Fork 241
Add color to log output #36
Conversation
daef7a0
to
69e6414
Compare
ff2bf4f
to
81158c0
Compare
I'm a bit perplexed by the build error I think this is a problem with recent version(s) of See tools/godep#377 |
Godeps/Godeps.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this wasn't already in Godeps.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a separate PR for just the unrelated godeps,
#37
We should probably rebase once that change is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I will do that once it's merged!
Update: I fixed the |
main.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package names should be lowercase,
https://blog.golang.org/package-names
Thanks for the changes @sandlerben, left a few minor comments |
Thanks for the comments @prashantv, most things should be fixed now. BTW, I realized why we use both |
Thanks for fixing @sandlerben, looks good to me. I merged the Godeps change, so once you rebase, I can merge this in |
@prashantv I rebased. Do you understand the build error? It seems like travis is trying to find the |
The issue is that the OSX has a case insensitive filesystem, so what you'll want to do is something like: mv torchLog torchlog_
mv torchlog_ torchlog |
@prashantv I tried that but |
Rename it, git commit it, then rename it back, then git commit it. After that, maybe just squash all the changes using |
@prashantv Ok awesome looks like it's working now! |
Sweet! |
No description provided.