Skip to content
This repository was archived by the owner on Mar 7, 2019. It is now read-only.

Conversation

sandlerben
Copy link
Contributor

No description provided.

@sandlerben sandlerben force-pushed the log-colors branch 3 times, most recently from daef7a0 to 69e6414 Compare January 6, 2016 05:20
@sandlerben
Copy link
Contributor Author

r @prashantv

@sandlerben sandlerben force-pushed the log-colors branch 2 times, most recently from ff2bf4f to 81158c0 Compare January 6, 2016 05:26
@sandlerben
Copy link
Contributor Author

I'm a bit perplexed by the build error Package (golang.org/x/sys/unix) not found

I think this is a problem with recent version(s) of godep because when I updated my local version of godep I got the same error.

See tools/godep#377

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this wasn't already in Godeps.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a separate PR for just the unrelated godeps,
#37

We should probably rebase once that change is merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I will do that once it's merged!

@sandlerben
Copy link
Contributor Author

Update: I fixed the golang.org/x/sys/unix issue by running godep get golang.org/x/sys/unix. For some reason go get golang.org/x/sys/unix hangs.

main.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package names should be lowercase,
https://blog.golang.org/package-names

@prashantv
Copy link
Contributor

Thanks for the changes @sandlerben, left a few minor comments

@sandlerben
Copy link
Contributor Author

Thanks for the comments @prashantv, most things should be fixed now.

BTW, I realized why we use both log.Print and fmt.Print. Logging writes to stderr but the fmt Print functions write to stdout.

@prashantv
Copy link
Contributor

Thanks for fixing @sandlerben, looks good to me.

I merged the Godeps change, so once you rebase, I can merge this in

@sandlerben
Copy link
Contributor Author

@prashantv I rebased. Do you understand the build error? It seems like travis is trying to find the torchlog package but can't find it.

@prashantv
Copy link
Contributor

The issue is that the torchLog.go is in the directory torchLog rather than torchlog. The case difference is tripping up travis.

OSX has a case insensitive filesystem, so what you'll want to do is something like:

mv torchLog torchlog_
mv torchlog_ torchlog

@sandlerben
Copy link
Contributor Author

@prashantv I tried that but git does not detect that anything changed.

@prashantv
Copy link
Contributor

Rename it, git commit it, then rename it back, then git commit it. After that, maybe just squash all the changes using git rebase into one.

@sandlerben
Copy link
Contributor Author

@prashantv Ok awesome looks like it's working now!

@prashantv
Copy link
Contributor

Sweet!

prashantv added a commit that referenced this pull request Jan 6, 2016
@prashantv prashantv merged commit 7fb644a into uber-archive:master Jan 6, 2016
@sandlerben sandlerben deleted the log-colors branch January 7, 2016 05:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants