Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce basic context.Context compatibility #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsenart
Copy link

@tsenart tsenart commented Apr 19, 2019

This change set introduces basic context.Context compatibility.

Specifically:

  • Adds a ConnectContext method to Conn and defines Connect in terms of it.
  • Adds a CallContext method to Conn and defines Call in terms of it.
  • Adds a PerformCallContext function and defines PerformCall in terms of it.
  • Adds a DialContext method to Dialer and defines Dial in terms of it.
  • Adds a DialContext function and defines Dial in terms of it.

Higher level utility methods such as ManifestCreateTask are left unchanged.

This change set introduces basic `context.Context` compatibility.

Specifically:
- Adds a `ConnectContext` method to `Conn` and defines `Connect` in
terms of it.
- Adds a `CallContext` method to `Conn` and defines `Call` in terms of it.
- Adds a `PerformCallContext` function and defines `PerformCall` in terms
of it.
- Adds a `DialContext` method to `Dialer` and defines `Dial` in terms of
it.
- Adds a `DialContext` function and defines `Dial` in terms of it.

Higher level utility methods such as `ManifestCreateTask` are left unchanged.
@CLAassistant
Copy link

CLAassistant commented Apr 19, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Tomás Senart seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants