Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added full support for vertex mode #71

Merged
merged 11 commits into from
Aug 26, 2024
Merged

feat: added full support for vertex mode #71

merged 11 commits into from
Aug 26, 2024

Conversation

mojixcoder
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Aug 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10435225163

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 95.986%
Totals Coverage Status
Change from base Build 10357246062: 0.2%
Covered Lines: 550
Relevant Lines: 573
💛 - Coveralls

@mojixcoder
Copy link
Contributor Author

Should I do more PRs for adding other vertex methods?
Or should I add them all in this PR?

@mojixcoder mojixcoder changed the title feat: added IsValidVertex feat: added full support for vertex mode Aug 17, 2024
@mojixcoder
Copy link
Contributor Author

mojixcoder commented Aug 17, 2024 •
edited
Loading

Update: I renamed the PR and added support for all vertex methods.
@isaacbrodsky

jogly
jogly approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@jogly jogly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jogly jogly merged commit 065469a into uber:master Aug 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogly jogly jogly approved these changes

@nrabinowitz nrabinowitz Awaiting requested review from nrabinowitz

@dfellis dfellis Awaiting requested review from dfellis

@ajfriend ajfriend Awaiting requested review from ajfriend

@isaacbrodsky isaacbrodsky Awaiting requested review from isaacbrodsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mojixcoder @CLAassistant @coveralls @jogly @isaacbrodsky