Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.6.2 polyfill breaking change from 3.5.0 #76

Closed
Pessimistress opened this issue Nov 19, 2019 · 3 comments
Closed

3.6.2 polyfill breaking change from 3.5.0 #76

Pessimistress opened this issue Nov 19, 2019 · 3 comments

Comments

@Pessimistress
Copy link

We previously used the following to generate all hexes at zoom 0:

h3
  .polyfill([[-90, -180], [90, -180], [90, 0], [-90, 0]], 0)
  .concat(h3.polyfill([[-90, 180], [90, 180], [90, 0], [-90, 0]], 0))

When upgrading to 3.6.2 from 3.5.0, the above code returns an empty array.

@nrabinowitz
Copy link
Collaborator

We have a dedicated function for this: h3.getRes0Indexes()

Can you use this instead? I agree that the behavior here should probably be considered a regression, but h3.getRes0Indexes() will be more reliable and considerably faster in any case.

@wilsotc
Copy link

wilsotc commented Dec 3, 2019

I'm seeing breaking changes with this function as well. At resolution 2 I'm getting empty results. For instance:
h3.polyfill([[162, 72],[153, 72],[153, 81],[162, 81]], 2);
[]

@nrabinowitz
Copy link
Collaborator

We investigated in the core library and we're working on a fix. In the meantime, 3.6.3 rolls back to a slow-but-correct version of polyfill that should fix the issue until we have a faster version available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants