Add back in a base cell test and remove constants.h from h3api.h

src/apps/testapps/testCompact.c

@@ -15,6 +15,7 @@
  */
 
 #include <stdlib.h>
+#include "constants.h"
 #include "h3Index.h"
 #include "test.h"
 

src/apps/testapps/testH3Index.c

@@ -22,6 +22,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include "constants.h"
 #include "h3Index.h"
 #include "test.h"
 #include "utility.h"
@@ -61,6 +62,14 @@ TEST(h3IsValidBaseCell) {
     }
 }
 
+TEST(h3FatIsValidBaseCellInvalid) {
+    H3Index hWrongBaseCell = H3_INIT;
+    H3_SET_MODE(hWrongBaseCell, H3_HEXAGON_MODE);
+    H3_SET_BASE_CELL(hWrongBaseCell, NUM_BASE_CELLS);
+    t_assert(!h3IsValid(hWrongBaseCell),
+             "h3IsValid failed on invalid base cell");
+}
+
 TEST(h3ToString) {
     const size_t bufSz = 17;
     char buf[17] = {0};

src/apps/testapps/testH3ToGeo.c

@@ -26,6 +26,7 @@
 
 #include <stdio.h>
 #include <stdlib.h>
+#include "constants.h"
 #include "geoCoord.h"
 #include "h3Index.h"
 #include "test.h"

src/apps/testapps/testHexRing.c

@@ -16,6 +16,7 @@
 
 #include <stdlib.h>
 #include "algos.h"
+#include "constants.h"
 #include "h3Index.h"
 #include "test.h"
 

src/apps/testapps/testPolyfill.c

@@ -16,6 +16,7 @@
 
 #include <stdlib.h>
 #include "algos.h"
+#include "constants.h"
 #include "geoCoord.h"
 #include "h3Index.h"
 #include "test.h"

src/h3lib/include/h3api.h

@@ -43,9 +43,6 @@
 /* For size_t */
 #include <stdlib.h>
 
-/* For constants used throughout H3 */
-#include "constants.h"
-
 /*
  * H3 is compiled as C, not C++ code. `extern "C"` is needed for C++ code
  * to be able to use the library.