[website] Fix LiveEditor so code is displayed in the documentation (e.g. quickstart) #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kinow
changed the title
kinow
changed the title
isaacbrodsky
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am experimenting with H3 for a project at $work, and noticed that all the live code editors were showing the same error message in the H3 website (screenshot from https://h3geo.org/docs/quickstart#point--cell):
I think it was due this this PR in docusaurus: facebook/docusaurus#5349
The
isClientwas removed from the context, so in the theme configuration,isClientis alwaysundefined. That causes thecodeto be always an empty string too.This PR uses the
useIsBrowserused in the linked PR in docusaurus. It works for me locally after this change 👍Thanks for H3 🚀
-Bruno