Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make warnings errors default only in Travis #90

Merged
merged 3 commits into from
Jul 11, 2018
Merged

Make warnings errors default only in Travis #90

merged 3 commits into from
Jul 11, 2018

Conversation

isaacbrodsky
Copy link
Collaborator

Fixes #88

@coveralls
Copy link

coveralls commented Jul 9, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 311dc99 on isaacbrodsky:warnings-as-errors-only-in-ci into db354ea on uber:master.

@nrabinowitz nrabinowitz changed the title Make warnigns errors default only in Travis Make warnings errors default only in Travis Jul 10, 2018
@jogly jogly self-requested a review July 11, 2018 17:47
isaachier
isaachier approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@isaachier isaachier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isaacbrodsky isaacbrodsky merged commit c05ce48 into uber:master Jul 11, 2018
@isaacbrodsky isaacbrodsky deleted the warnings-as-errors-only-in-ci branch July 11, 2018 18:16
mrdvt92 pushed a commit to mrdvt92/h3 that referenced this pull request Jun 19, 2022
@isaacbrodsky
Merge pull request uber#90 from isaacbrodsky/warnings-as-errors-only-…
0cf6aaa 
…in-ci

Make warnings errors default only in Travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaachier isaachier isaachier approved these changes

@jogly jogly jogly approved these changes

@nrabinowitz nrabinowitz nrabinowitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isaacbrodsky @coveralls @nrabinowitz @jogly @isaachier