Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on x86 and apple silicon #918

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Test on x86 and apple silicon #918

merged 1 commit into from
Sep 27, 2024

Conversation

ajfriend
Copy link
Contributor

@ajfriend ajfriend commented Sep 27, 2024

We've seen a bug (#917) that appears on Apple Silicon but not x86, so adding to the build matrix to test across both.

Also, I shorten the job name so we can see the OS version in the github actions web UI.

Note, I don't think there's a way to guarantee architecture, but it seems like it is usually correlated with macos version:
https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

@coveralls
Copy link

Coverage Status

coverage: 98.825%. remained the same
when pulling 2f189c1 on aj/macos_tests
into 9cc20fd on master.

@ajfriend
Copy link
Contributor Author

image

If everyone agrees, I can make the same name change on the other tests.

@isaacbrodsky
Copy link
Collaborator

isaacbrodsky commented Sep 27, 2024

I've changed the branch protection rules to not require the previous test names and will update them to require the new ones right after merging

edit: branch protection rules are updated

@isaacbrodsky isaacbrodsky merged commit b355c9d into master Sep 27, 2024
38 checks passed
@isaacbrodsky isaacbrodsky deleted the aj/macos_tests branch September 27, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants