This repository was archived by the owner on Aug 17, 2025. It is now read-only.
Add adapters for go-kit metrics and a factory for expvar #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
black-adder
reviewed
Feb 9, 2017
glide.yaml
Outdated
| import: | ||
| - package: github.com/codahale/hdrhistogram | ||
| - package: github.com/go-kit/kit | ||
| subpackages: |
There was a problem hiding this comment.
it generated this without any subpackages?
There was a problem hiding this comment.
sorry, I tried to add them manually, but glide complained. Removed.
metrics/go-kit/expvar/factory.go
Outdated
| return f.scope + "_" + name | ||
| } | ||
|
|
||
| func (f factory) Counter(name string, tags map[string]string) metrics.Counter { |
There was a problem hiding this comment.
does go-kit metrics not have a way to deal with tags?
There was a problem hiding this comment.
oops, you're correct, I got focused on expvar implementation that does not support tags
metrics/go-kit/expvar/factory.go
Outdated
| return xkit.NewGauge(kit.NewGauge(f.subScope(name))) | ||
| } | ||
|
|
||
| // Namespace is a no-op for expvar, since i |
|
|
1 similar comment
black-adder
approved these changes
Feb 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the pattern I was asking for in go-kit/kit#378, simplified for our needs.