Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove writing into redundant cache in build-index #155

Merged
merged 3 commits into from
May 13, 2019
Merged

Remove writing into redundant cache in build-index #155

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f43c13d
Merge pull request #1 from uber/master
EltonzHu May 2, 2019
e865ada
Merge pull request #2 from uber/master
EltonzHu May 10, 2019
973a482
Remove writing into redundant cache in build-index after pulling tag …
EltonzHu May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions build-index/tagstore/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import (
"github.com/uber/kraken/lib/persistedretry/writeback"
"github.com/uber/kraken/lib/store"
"github.com/uber/kraken/lib/store/metadata"
"github.com/uber/kraken/utils/log"

"github.com/uber-go/tally"
)
Expand Down Expand Up @@ -160,8 +159,5 @@ func (s *tagStore) resolveFromBackend(tag string) (core.Digest, error) {
if err != nil {
return core.Digest{}, fmt.Errorf("parse backend digest: %s", err)
}
if err := s.writeTagToDisk(tag, d); err != nil {
log.With("tag", tag).Errorf("Error writing tag to disk: %s", err)
}
return d, nil
}