Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GA to website #65

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Add GA to website #65

merged 1 commit into from
Nov 7, 2019

Conversation

javidhsueh
Copy link
Contributor

Summary | Related Issue(s)

Fixes #64

Changes

  • Update html-webpack-plugin version
  • Add new dependency "html-webpack-partials-plugin" for injecting GA script.

Test Plan

Tested in my browser.

Checklist

  • [v] I have made this PR atomic.
  • [v] I have provided enough context for others to review.
  • [v] I have added tests to cover my changes (for features and bug fixes).
  • [v] I have updated the documentation and changelogs accordingly.
  • [v] All new and existing tests passed.

@javidhsueh javidhsueh merged commit ea86488 into master Nov 7, 2019
@Firenze11 Firenze11 mentioned this pull request Nov 26, 2019
Closed
@Firenze11 Firenze11 deleted the javid/website branch February 23, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnavvy gnavvy gnavvy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Google analytics to the website
2 participants
@javidhsueh @gnavvy