Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of log levels #93

Closed
marciniwanicki opened this issue Mar 1, 2020 · 0 comments · Fixed by #94
Closed

Order of log levels #93

marciniwanicki opened this issue Mar 1, 2020 · 0 comments · Fixed by #94

Comments

@marciniwanicki
Copy link
Collaborator

The current order of log levels:

public enum LogLevel: Int {
    case info
    case verbose
    case warning
    case error
}

Having those levels is nice as it allows the client code to decide how much information should be logged (or presented to the users).

The order of log levels is smoothly distributed between the most verbose (like verbose, trace or debug) and critical (error or critical etc).

I think the info and verbose cases could be swapped to allow uses to specify info if they want to know only general information about the generation process, or verbose if they the want to dig into details.

marciniwanicki added a commit that referenced this issue Mar 3, 2020
Resolves #93

Ensures `verbose` log level prints out more details than `info`. Updated signpost methods to be active only when `verbose` log level is used.  Signpost traces will not be collected for `info`, `warn`, and `error` levels.

Signed-off-by: Marcin Iwanicki <marcin@iwanicki.me>
uhooi pushed a commit to uhooi/mockolo that referenced this issue Apr 27, 2021
Resolves uber#93

Ensures `verbose` log level prints out more details than `info`. Updated signpost methods to be active only when `verbose` log level is used.  Signpost traces will not be collected for `info`, `warn`, and `error` levels.

Signed-off-by: Marcin Iwanicki <marcin@iwanicki.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant