-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update swift-syntax to 509.0.0 #247
Conversation
The `name` property of `EntityNode` has been renamed to `nameText` to avoid clashing with the new `name` property of conforming types (`ProtocolDeclSyntax` and `ClassDeclSyntax`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@rudro plz merge :) |
Hello @sidepelican @uhooi, is there something else required so that this can be merged? |
We are already not maintainers and do not have the authority to merge. According to #220, @rudro @alanzeino seems to be the maintainer, but I haven't seen much of them. |
Sorry, I assumed you could still merge. Let me check the permissions. |
@sidepelican can you show me what message you see on your end? I've double checked our branch protection rules and you should be able to merge as you have write permissions, along with @uhooi The only thing I can't really tell is if Uber has an organization global protection rule that doesn't allow non–Uber employees to merge PRs. I'll have to get back to you on that. For now, I'll merge this. In future if you at–mention me I can merge until we resolve this. |
@alanzeino The following message will be displayed:
|
Same. |
Updated the |
@alanzeino thx!! |
I also changed that; to match other projects at Uber. |
The codebase is being updated to work with swift-syntax 509.0.0