Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swift-syntax to 509.0.0 #247

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

pablocornejo
Copy link
Contributor

The codebase is being updated to work with swift-syntax 509.0.0

Copy link
Collaborator

@sidepelican sidepelican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@uhooi
Copy link
Collaborator

uhooi commented Sep 28, 2023

@rudro plz merge :)

@pablocornejo
Copy link
Contributor Author

Hello @sidepelican @uhooi, is there something else required so that this can be merged?

@sidepelican
Copy link
Collaborator

We are already not maintainers and do not have the authority to merge.

According to #220, @rudro @alanzeino seems to be the maintainer, but I haven't seen much of them.

@alanzeino
Copy link
Collaborator

Sorry, I assumed you could still merge. Let me check the permissions.

@alanzeino
Copy link
Collaborator

@sidepelican can you show me what message you see on your end? I've double checked our branch protection rules and you should be able to merge as you have write permissions, along with @uhooi

Screenshot 2024-02-13 at 19 10 50

The only thing I can't really tell is if Uber has an organization global protection rule that doesn't allow non–Uber employees to merge PRs. I'll have to get back to you on that. For now, I'll merge this.

In future if you at–mention me I can merge until we resolve this.

@alanzeino alanzeino merged commit df35505 into uber:master Feb 14, 2024
4 checks passed
@uhooi
Copy link
Collaborator

uhooi commented Feb 14, 2024

@alanzeino The following message will be displayed:

You’re not authorized to merge this pull request.

image

@sidepelican
Copy link
Collaborator

Same.

@alanzeino
Copy link
Collaborator

Updated the Branch protection rule settings, should work now.

@uhooi
Copy link
Collaborator

uhooi commented Feb 19, 2024

@alanzeino thx!!
I can't select "Create a merge commit", can I just "Squash and merge"?
image

@alanzeino
Copy link
Collaborator

I also changed that; to match other projects at Uber.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants