Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out ModeHandlers #100

Merged
merged 10 commits into from
Oct 9, 2018
Merged

Factor out ModeHandlers #100

merged 10 commits into from
Oct 9, 2018

Conversation

supersonicclay
Copy link
Collaborator

@supersonicclay supersonicclay commented Oct 5, 2018 •
edited
Loading

TODO

  • drawRectangle POC
  • factor out other draw modes
  • factor out rest of modes
  • sample of some tests
  • ability to override handlers via props
  • documentation

@supersonicclay supersonicclay self-assigned this Oct 5, 2018
@supersonicclay supersonicclay changed the title Factor out ModeHandlers WIP: Factor out ModeHandlers Oct 5, 2018
@supersonicclay supersonicclay changed the title WIP: Factor out ModeHandlers Factor out ModeHandlers Oct 7, 2018
@supersonicclay supersonicclay force-pushed the clay/mode-handlers branch 2 times, most recently from fa3487d to 25aa520 Compare October 8, 2018 15:54
@supersonicclay supersonicclay mentioned this pull request Oct 8, 2018
Merged
georgios-uber
georgios-uber approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@georgios-uber georgios-uber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! That is very good work!!!

@supersonicclay supersonicclay merged commit 83f6235 into master Oct 9, 2018
@supersonicclay supersonicclay deleted the clay/mode-handlers branch October 9, 2018 01:46
@supersonicclay supersonicclay mentioned this pull request Oct 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgios-uber georgios-uber georgios-uber approved these changes

@jonpeters jonpeters Awaiting requested review from jonpeters

@sivako sivako Awaiting requested review from sivako

Assignees

@supersonicclay supersonicclay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supersonicclay @georgios-uber