Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new editor module and example app #349

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Add new editor module and example app #349

merged 2 commits into from
Mar 13, 2020

Conversation

supersonicclay
Copy link
Collaborator

  • Adds a new @nebula.gl/editor module
  • Adds a super-basic Toolbox component just to show how props and callbacks can flow
  • Adds a new editor example so that we can experiment.

@@ -0,0 +1,5996 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't commit the lockfiles inside examples.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been for the other ones. Let's tackle removing them if it makes sense in another PR.

yarn.lock Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1703

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 29.605%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/editor/src/toolbox.js 0 9 0.0%
Totals Coverage Status
Change from base Build 1692: -0.07%
Covered Lines: 1061
Relevant Lines: 3453

💛 - Coveralls

@supersonicclay supersonicclay merged commit a6c603d into master Mar 13, 2020
@supersonicclay supersonicclay deleted the import branch March 13, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants