Remove double click handlers from nebula layers and edit-modes #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1968
💛 - Coveralls |
austintang
force-pushed
the
atang-dblclick-event
branch
from
0198c88
to
914ab0e
Compare
austintang
commented
Jun 1, 2020
| @@ -1021,8 +1021,7 @@ export default class Example extends React.Component< | |||
| id: 'basemap', | |||
| controller: { | |||
| type: MapController, | |||
| // @ts-ignore | |||
| doubleClickZoom: this.state.mode === 'view' && !this.state.selectionTool, | |||
There was a problem hiding this comment.
I feel like disabling double click to zoom will make nebula feel more snappy and responsive since deck won't debounce clicks with doubleClickZoom: false. In my opinion, the benefits of this change outweigh the utility that double click to zoom provides.
supersonicclay
approved these changes
Jun 2, 2020
xintongxia
reviewed
Jun 2, 2020
| @@ -308,12 +307,6 @@ export default class ModeHandler extends React.PureComponent<EditorProps, Editor | |||
| this._modeHandler.handleClick(event, modeProps); | |||
| }; | |||
|
|
|||
| _onDblclick = (event: BaseEvent) => { | |||
There was a problem hiding this comment.
react-map-gl-draw is not using deck.gl as renderer. so this should be kept.
There was a problem hiding this comment.
Got it. I'll revert my changes in the react-map-gl-draw module.
austintang
changed the title
xintongxia
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation, all layers that extend
EditableLayeradd event handlers for thedblclickevent even whenEditableLayer.onDoubleClick()isn't overridden. The problem is that deck.gl performs click debouncing whendblclickhandler is provided, making clicks feel laggy and in some cases, drop clicks altogether.The following is how
EditableLayerscurrently behave. Notice the delay in the layer's response after clicking on features:Here is how the layer behaves after applying this diff:
As a side note, if a single layer adds a
dblclickhandler, all deck layers will experience this debouncing effect. Because of this, I do not recommend that any layers adddblclickhandlers.