Tentative Feature #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersonicclay
force-pushed
the
clay/tentative-feature
branch
4 times, most recently
from
24d92bf
to
ec0e6d7
Compare
supersonicclay
force-pushed
the
clay/tentative-feature
branch
from
7efc841
to
778cedd
Compare
Leave it up to the consuming application to mange selection and mode. less surprises for developers => happy developers
Closed
supersonicclay
force-pushed
the
clay/tentative-feature
branch
from
7327936
to
e302314
Compare
supersonicclay
force-pushed
the
clay/tentative-feature
branch
from
e302314
to
c84ade5
Compare
supersonicclay
force-pushed
the
clay/tentative-feature
branch
from
c84ade5
to
7b62079
Compare
georgios-uber
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling
onEditfor tentative features, store then internally in nebula.gl.So, for example:
drawLineString, only callonEditwhen two points are clicked (i.e. don't add aPointfeature)drawPolygon,drawRectangleUsing3Points), only callonEditwhen the polygon is complete (i.e. don't add aPointorLineStringfeature)This means nebula will no longer "upgrade" geometry types.
In action
More Testable
Much of the pointer move and click functionality was factored out of
EditableGeoJsonLayerintoEditableFeatureCollection. So, it should be much more testable going forward.Other fixes
Fixes #69
TODO
[X] POC with
drawLineString[X] Refactor other draw modes
[X] delete
updatedMode[X] delete
updatedSelectedFeatureIndexes[X] Rename "draw" to "tentative" for rendering props
[X] Documentation
[X] Add example of test for onPointerMove
[X] Add example of test for onClick
[ ] Refactor add intermediate position?
[ ] Refactor move position?
[ ] Refactor rotate?