Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep NeedleFoundation for dynamic code path #433

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Prep NeedleFoundation for dynamic code path #433

merged 3 commits into from
Jul 25, 2022

Conversation

rudro
Copy link
Collaborator

@rudro rudro commented Jul 21, 2022

  • Note all the changes are pretty much dead-code for now as they are guarded by #if statements

Start of implementation of #432

- Note all the changes are pretty much dead-code for now as they are guarded by #if statements

Start of implementation of #432
@rudro rudro requested review from wbond and ryanaveo July 21, 2022 18:12
Copy link
Collaborator

@wbond wbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me.

One thing that would be nice would be a readme doc explaining the difference in approach between the dynamic and static approaches, possibly with some light textual diagrams.

- Both for the current generated code as well as the new dynamic path
@rudro rudro merged commit 8c86378 into master Jul 25, 2022
@rudro rudro deleted the rudro_foundation branch July 26, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants