Do not rely on static variable initialization order in the backend registrar. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivekPanyam
reviewed
Feb 8, 2019
| { | ||
| registered_backends_by_name = new std::unordered_map<std::string, BackendFactoryFunction>(); | ||
| registered_backends_by_type = new std::unordered_map<std::string, BackendFactoryFunction>(); | ||
| } |
There was a problem hiding this comment.
We should probably also do this in get_backend_for_type and get_backend_by_name just to be safe.
Maybe move these 4 lines into a separate function called initialize_registered_backends_if_needed or something and call it from all 3 places.
Also, as you said, making this initialization threadsafe is probably a good idea
There was a problem hiding this comment.
(We could also just do a null check in the other two functions)
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.