[Tools] Add initial support for clang-tidy #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
=======================================
Coverage 90.44% 90.44%
=======================================
Files 63 63
Lines 3788 3788
=======================================
Hits 3426 3426
Misses 362 362 Continue to review full report at Codecov.
|
selitvin
approved these changes
Mar 19, 2020
|
|
||
| echo "Generating compile commands..." | ||
|
|
||
| mkdir -p /tmp/bazel-compdb |
There was a problem hiding this comment.
Consider using a random temporary directory - so multiple runs could co-exist. Might be helpful in some scenarios?
There was a problem hiding this comment.
We want that directory to persist so we don't have to redownload the tool on every invocation. The directory just stores the bazel-compdb tool so it should be fine for multiple instances of the repo to use the same directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for running clang-tidy locally. It will be enabled in CI once all reported issues are fixed.