Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check to fail build on invalid local dependencies #288

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Add a check to fail build on invalid local dependencies #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions buildSrc/src/main/groovy/com/uber/okbuck/core/model/base/Scope.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import com.uber.okbuck.core.model.jvm.JvmTarget
import com.uber.okbuck.core.util.FileUtil
import com.uber.okbuck.core.util.ProjectUtil
import groovy.transform.EqualsAndHashCode
import org.apache.commons.io.FilenameUtils
import org.gradle.api.Project
import org.gradle.api.artifacts.Configuration
import org.gradle.api.artifacts.ResolvedArtifact
Expand Down Expand Up @@ -129,6 +130,11 @@ class Scope {
files.findAll { File resolved ->
!resolvedFiles.contains(resolved)
}.each { File localDep ->
if (!FilenameUtils.directoryContains(project.rootProject.projectDir.absolutePath, localDep.absolutePath)) {
throw new IllegalStateException("Local dependencies should be under project root. Dependencies " +
"outside the project can cause hard to reproduce builds. Please move dependency: ${localDep} " +
"inside ${project.rootProject.projectDir}")
}
external.add(ExternalDependency.fromLocal(localDep))
}
}
Expand Down