Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for classifiers in external dependencies #388

Merged
merged 6 commits into from
Feb 9, 2017
Merged

Add support for classifiers in external dependencies #388

merged 6 commits into from
Feb 9, 2017

Commits on Feb 9, 2017

  1. Issue #375 - Add jar classifiers to the dependency cache.

    Chris Woodward authored and Gautam Korlam committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    2937300 View commit details
    Browse the repository at this point in the history

  2. Made changes to make field classifier final in VersionlessDependency.

    Chris Woodward authored and Gautam Korlam committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    51d36a5 View commit details
    Browse the repository at this point in the history

  3. Removed artifact type check for jars.

    Chris Woodward authored and Gautam Korlam committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    b146391 View commit details
    Browse the repository at this point in the history

  4. Add support for AARs 

    Two reasons why the default needs to be “debug”:
1.) If the default is null, ProjectDependency will resolve to a
different cache entry than its AAR ExternalDependency.
2.) On subsequent runs of the OkBuck task, the cache has been populated
and all artifacts have a null classifier. This would cause conflict
with those that had classifiers originally.
    Chris Woodward authored and Gautam Korlam committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    fbc972b View commit details
    Browse the repository at this point in the history

  5. Do not hardcode classifer for aars

    Gautam Korlam committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    4d16005 View commit details
    Browse the repository at this point in the history

  6. simplify naming

    Gautam Korlam committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    25db2cf View commit details
    Browse the repository at this point in the history