Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to kotlin in memory compiler support in buck #450

Merged
merged 2 commits into from
Jun 5, 2017

Conversation

kageiit
Copy link
Contributor

@kageiit kageiit commented May 26, 2017

Waiting on facebook/buck#1283 to merge before merging this

@kageiit kageiit requested review from w4nderlust and removed request for w4nderlust May 26, 2017 18:27
Copy link
Contributor

@runningcode runningcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I love that we're getting rid of the custom kotlinc!

@runningcode
Copy link
Contributor

Should you bump the kotlin version in dependencies.gradle?

@kageiit
Copy link
Contributor Author

kageiit commented May 26, 2017

Should you bump the kotlin version in dependencies.gradle?

Yes I plan to bump that and buckversion when the upstream changes merge. This was just put up ahead of time

@kageiit kageiit force-pushed the kotlin_in_memory_compiler branch from b7a43db to 226aaa8 Compare June 5, 2017 20:35
@kageiit kageiit merged commit 74789cd into master Jun 5, 2017
@kageiit kageiit deleted the kotlin_in_memory_compiler branch June 5, 2017 21:19
cwoodwar6 pushed a commit to cwoodwar6/okbuck that referenced this pull request Jun 27, 2017
* uber/master:
  Setup Kotlin home whenever the kotlin gradle plugin is on the classpath. (uber#464)
  Update several dependencies to latest (uber#462)
  Remove kotlin-dev repo as 1.1.3 is now released
  Add support for mixed kotlin and java in regular kotlin modules. (uber#461)
  Publish v0.22.1
  Fix rule type propagation
  Publish v0.22.0
  Update kotlin, gradle and buck versions (uber#460)
  Add kotlin android integration test and fixup source detection (uber#459)
  Kotlin Android Support (uber#458)
  Use more abstractions (uber#457)
  Prefer abstractions over implementations for upcoming kotlin refactors (uber#456)
  Add option to exclude some resources from aapt (uber#455)
  Bump to gradle 4.0 stable. (uber#454)
  Publish v0.21.0
  Migrate to kotlin in memory compiler support in buck (uber#450)
  Change how dependencies are resolved in preparation for Andrioid Gradle Plugin 3.x (uber#451)
  Switch the ordering of build config fields. (uber#449)
  Publish v0.20.10
  Revert "Add empty resource rule if using resource union. (uber#438)"
cwoodwar6 pushed a commit to cwoodwar6/okbuck that referenced this pull request Jul 27, 2017
* upstream/master:
  Publish v0.21.0
  Migrate to kotlin in memory compiler support in buck (uber#450)
  Change how dependencies are resolved in preparation for Andrioid Gradle Plugin 3.x (uber#451)
  Switch the ordering of build config fields. (uber#449)
  Publish v0.20.10
  Revert "Add empty resource rule if using resource union. (uber#438)"
cwoodwar6 pushed a commit to cwoodwar6/okbuck that referenced this pull request Jul 27, 2017
…o master

* commit '59bc6fbe8b69da8ca16adbc600928eeafab69ed1':
  Publish v0.21.0
  Migrate to kotlin in memory compiler support in buck (uber#450)
  Change how dependencies are resolved in preparation for Andrioid Gradle Plugin 3.x (uber#451)
  Switch the ordering of build config fields. (uber#449)
  Publish v0.20.10
  Revert "Add empty resource rule if using resource union. (uber#438)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants