Added missing dependencies and annotation processor dependencies to exo app lib rule #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwoodwar6
pushed a commit
to cwoodwar6/okbuck
that referenced
this pull request
Apr 19, 2018
…ream * upstream/master: (41 commits) Add better error message when not defining a repositories block. (uber#574) Publish v0.32.1 Added missing annotation processor dependencies to exo app lib rule (uber#566) Publish v0.32.0 Update to support robolectric 3.6 (uber#565) Cleanup buckw and make some usability improvements (uber#564) Publish v0.31.6 Set package_type in android_binary rules Do not use manifest_skeleton for instrumentation apk rules Publish v0.31.5 Do not generate lint rules for instrumentation sources Publish v0.31.4 Add ability to customize kotlin version independent of classpath dependencies Publish v0.31.3 Use manifest skeleton in instrumentation apks Publish v0.31.2 Update gradle to 4.4-rc-1 Update default buck version in wrapper Move okbuck to generate modern manifest skeleton based android_binary rules (uber#560) Publish v0.31.1 ...
cwoodwar6
pushed a commit
to cwoodwar6/okbuck
that referenced
this pull request
Apr 19, 2018
…am to master * commit '99b6bf78fd68816c2fa2e4f0836557eef0eebc43': (42 commits) Fix duplicate enum in RobolectricUtil Add better error message when not defining a repositories block. (uber#574) Publish v0.32.1 Added missing annotation processor dependencies to exo app lib rule (uber#566) Publish v0.32.0 Update to support robolectric 3.6 (uber#565) Cleanup buckw and make some usability improvements (uber#564) Publish v0.31.6 Set package_type in android_binary rules Do not use manifest_skeleton for instrumentation apk rules Publish v0.31.5 Do not generate lint rules for instrumentation sources Publish v0.31.4 Add ability to customize kotlin version independent of classpath dependencies Publish v0.31.3 Use manifest skeleton in instrumentation apks Publish v0.31.2 Update gradle to 4.4-rc-1 Update default buck version in wrapper Move okbuck to generate modern manifest skeleton based android_binary rules (uber#560) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated app_lib_exo rule, of type android_library, doesn't support specifying annotation processor deps. While this shouldn't be needed normally, it prevents to apply any plugin through extra params or annotation processor to the exo module.