Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump android gradle plugin to 3.6.1 #905

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Bump android gradle plugin to 3.6.1 #905

merged 3 commits into from
Jul 16, 2020

Conversation

raviagarwal7
Copy link
Collaborator

@raviagarwal7 raviagarwal7 commented Mar 26, 2020 •
edited
Loading 

-        androidPlugin      : "3.2.0",
-        androidTools       : "26.2.0",
-        butterKnife        : "10.0.0",
-        dagger             : "2.16",
-        kotlin             : "1.3.21",
+        androidPlugin      : "3.6.1",
+        androidTools       : "26.6.1",
+        butterKnife        : "10.2.1",
+        dagger             : "2.28.1",
+        kotlin             : "1.3.72",
  • Bump robolectric to 4.3.1
  • Materialize kotlin_home target as part of buckw so the build works with oss buck.

@raviagarwal7 raviagarwal7 requested review from kageiit and thalescm and removed request for kageiit March 26, 2020 13:29
kageiit
kageiit reviewed Mar 26, 2020
View reviewed changes
dependencies.gradle Outdated
@@ -17,11 +17,11 @@ def exclude = { dep, String... excludes ->
}

def versions = [
androidPlugin : "3.2.0",
androidPlugin : "3.6.1",
androidTools : "26.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to bump tools also to 26.6.1

@raviagarwal7 raviagarwal7 mentioned this pull request Jul 14, 2020
Closed
@raviagarwal7 raviagarwal7 force-pushed the ravi/agp branch 4 times, most recently from 07c1c2d to 3c08362 Compare July 15, 2020 20:54
kageiit
kageiit suggested changes Jul 15, 2020
View reviewed changes
buildSrc/build.gradle Outdated
@@ -101,7 +101,7 @@ task sourcesJar(type: Jar) {
classifier = "sources"
}

def publishVersion = "0.50.10"
def publishVersion = "0.50.11-LOCAL"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo

dependencies.gradle Outdated
@@ -82,6 +82,7 @@ def external = [
kotlinExtension : "org.jetbrains.kotlin:kotlin-android-extensions:${versions.kotlin}",
kotlinStdlib : "org.jetbrains.kotlin:kotlin-stdlib:${versions.kotlin}",
leakCanary : "com.squareup.leakcanary:leakcanary-android:${versions.leakCanary}",
sqldelight : "com.squareup.sqldelight:android-driver:1.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move 1.4.0 to versions

gradle/wrapper/gradle-wrapper.properties Outdated
@@ -1,5 +1,6 @@
#Wed Jul 15 22:50:36 CEST 2020
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove timestamp

@raviagarwal7
Copy link
Collaborator Author 

Warning: com.google.android.material.tabs.TabLayout$TabView: can't find referenced class androidx.appcompat.content.res.AppCompatResources
Warning: com.google.android.material.tabs.TabLayout$TabView: can't find referenced class androidx.appcompat.content.res.AppCompatResources
Warning: com.google.android.material.textfield.TextInputLayout: can't find referenced class androidx.appcompat.widget.DrawableUtils
Warning: com.google.android.material.textfield.TextInputLayout: can't find referenced class androidx.appcompat.widget.DrawableUtils
Warning: com.google.android.material.textfield.TextInputLayout: can't find referenced class androidx.appcompat.content.res.AppCompatResources
Warning: com.google.android.material.textfield.TextInputLayout: can't find referenced class androidx.appcompat.content.res.AppCompatResources
Warning: there were 192 unresolved references to classes or interfaces.
         You may need to add missing library jars or update their versions.
         If your code works fine without the missing classes, you can suppress
         the warnings with '-dontwarn' options.
         (http://proguard.sourceforge.net/manual/troubleshooting.html#unresolvedclass)
Warning: there were 3 unresolved references to program class members.
         Your input classes appear to be inconsistent.
         You may need to recompile the code.
         (http://proguard.sourceforge.net/manual/troubleshooting.html#unresolvedprogramclassmember)
java.io.IOException: Please correct the above warnings first.
	at proguard.Initializer.execute(Initializer.java:485)
	at proguard.ProGuard.initialize(ProGuard.java:285)
	at proguard.ProGuard.execute(ProGuard.java:114)
	at proguard.ProGuard.main(ProGuard.java:594)

    When running <proguard_obfuscation>.
    When building rule //another-app:bin_release#class_file_to_dex_processing.

The build now fails at the proguard step. @kageiit do you know what might be up?

@kageiit
Copy link
Contributor

kageiit commented Jul 15, 2020 

Warning: com.google.android.material.tabs.TabLayout$TabView: can't find referenced class androidx.appcompat.content.res.AppCompatResources
Warning: com.google.android.material.tabs.TabLayout$TabView: can't find referenced class androidx.appcompat.content.res.AppCompatResources
Warning: com.google.android.material.textfield.TextInputLayout: can't find referenced class androidx.appcompat.widget.DrawableUtils
Warning: com.google.android.material.textfield.TextInputLayout: can't find referenced class androidx.appcompat.widget.DrawableUtils
Warning: com.google.android.material.textfield.TextInputLayout: can't find referenced class androidx.appcompat.content.res.AppCompatResources
Warning: com.google.android.material.textfield.TextInputLayout: can't find referenced class androidx.appcompat.content.res.AppCompatResources
Warning: there were 192 unresolved references to classes or interfaces.
         You may need to add missing library jars or update their versions.
         If your code works fine without the missing classes, you can suppress
         the warnings with '-dontwarn' options.
         (http://proguard.sourceforge.net/manual/troubleshooting.html#unresolvedclass)
Warning: there were 3 unresolved references to program class members.
         Your input classes appear to be inconsistent.
         You may need to recompile the code.
         (http://proguard.sourceforge.net/manual/troubleshooting.html#unresolvedprogramclassmember)
java.io.IOException: Please correct the above warnings first.
	at proguard.Initializer.execute(Initializer.java:485)
	at proguard.ProGuard.initialize(ProGuard.java:285)
	at proguard.ProGuard.execute(ProGuard.java:114)
	at proguard.ProGuard.main(ProGuard.java:594)

    When running <proguard_obfuscation>.
    When building rule //another-app:bin_release#class_file_to_dex_processing.

The build now fails at the proguard step. @kageiit do you know what might be up?

@kurtisnelson bumped proguard in a recent PR. try to revert those changes and check?

@kurtisnelson
Copy link
Contributor

I didn't actually bump the version though, just the handling logic.

This was referenced Jul 16, 2020
Closed
Closed
@raviagarwal7 raviagarwal7 mentioned this pull request Jul 16, 2020
Closed
@kageiit kageiit merged commit 056db90 into master Jul 16, 2020
@kageiit kageiit deleted the ravi/agp branch August 27, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kageiit kageiit kageiit approved these changes

@thalescm thalescm Awaiting requested review from thalescm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OkBuck is incompatible with AGP 3.4.0
3 participants
@raviagarwal7 @kageiit @kurtisnelson