-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for exporting raw dependencies #973
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buildSrc/src/main/java/com/uber/okbuck/core/util/ProjectUtil.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/uber/okbuck/core/dependency/exporter/DependencyExporterModel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we reformat the added/modified files with google-java-formatter
buildSrc/src/main/java/com/uber/okbuck/extension/ExportDependenciesExtension.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/uber/okbuck/extension/OkBuckExtension.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/uber/okbuck/extension/OkBuckExtension.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/uber/okbuck/core/manager/DependencyManager.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/uber/okbuck/core/dependency/exporter/DependencyExporterModel.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/uber/okbuck/core/dependency/exporter/DependencyExporterModel.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/uber/okbuck/core/dependency/exporter/ExporterException.java
Show resolved
Hide resolved
raviagarwal7
approved these changes
Feb 16, 2023
hvvikram
force-pushed
the
export-raw-deps
branch
from
February 16, 2023 23:41
e36ffe4
to
9115815
Compare
plugin can accept two project parameters * exportDependencies: to enable exporting of raw dependencies * exportDependenciesFile: Name with optional relative path from the root of the project where the dependencies will be exported ( default: .okbuck/raw-deps ) Supports exporting raw dependencies in JSON format. ``` ./gradlew okbuck -PexportDependencies=true -PexportDependenciesFile=.okbuck/raw-deps.json ```
… group:module when both are not blank
* Ran google formatter * Autoclose BufferedWriter to flush the contents and close
hvvikram
force-pushed
the
export-raw-deps
branch
from
February 16, 2023 23:47
9115815
to
edb856f
Compare
raviagarwal7
approved these changes
Feb 17, 2023
vicmns
pushed a commit
to vicmns/okbuck
that referenced
this pull request
May 31, 2023
* feat: Add support for exporting raw dependencies plugin can accept two project parameters * exportDependencies: to enable exporting of raw dependencies * exportDependenciesFile: Name with optional relative path from the root of the project where the dependencies will be exported ( default: .okbuck/raw-deps ) Supports exporting raw dependencies in JSON format. ``` ./gradlew okbuck -PexportDependencies=true -PexportDependenciesFile=.okbuck/raw-deps.json ``` * Moved configurations to OKBuckExtension and handle excludeRule to use group:module when both are not blank * * Addressed review comments * Ran google formatter * Autoclose BufferedWriter to flush the contents and close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add support for exporting raw dependencies
plugin can accept the following configuration
Supports exporting raw dependencies in JSON format.
Example exported json snippet:
Related issue(s):