Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Android SDK 32, 33, 34 #983

Merged
merged 17 commits into from
Dec 18, 2023
Merged

Conversation

gpolak
Copy link
Contributor

@gpolak gpolak commented Dec 15, 2023

Description:

  • adding support for latest Android SDKs
  • bumping test instrumentation to i4 to match production

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2023

CLA assistant check
All committers have signed the CLA.

@gpolak gpolak requested a review from tyvsmith December 15, 2023 20:39
Copy link
Member

@tyvsmith tyvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.54.2 was cut already as the key signing rotation (no code changes). Looks like he just missed the changelog, or technically there was no code change 🤷🏻 , so we'll need to use .54.3.

https://central.sonatype.com/artifact/com.uber/okbuck

@gpolak
Copy link
Contributor Author

gpolak commented Dec 15, 2023

@tyvsmith bumped the version to 0.54.3

README-zh.md Outdated Show resolved Hide resolved
@@ -16,6 +17,7 @@ buck-out
**/BUCK

buildSrc/bintray.properties
buildSrc/secring.gpg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helps with local testing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I don't think there should be a dev flow where there's a local secring. The signings creds should live in $HOME/.gradle which is outside the repo, and the secreing typically sits in a separate user path.

This is fine overall, as it's mostly a no-op. Just more curious on the flow that made this needed.

@gpolak
Copy link
Contributor Author

gpolak commented Dec 16, 2023

@tyvsmith, all green now. I didn't update the pre-instrumented version in TestExtension.java due to the same failure as the old PR here. I highlighted the underlying issue in the comment there. We can address this in a separate diff.

@gpolak gpolak requested a review from tyvsmith December 18, 2023 00:59
@gpolak gpolak changed the title Add lastest Android SDK support Add support for Android SDK 32, 33, 34 Dec 18, 2023
@gpolak gpolak merged commit 4863835 into master Dec 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants