Merge pull request #110 from uber/revert-109-revert-107-pyro-bug-fix2

re-run this merge to cover right issues and close those issues including previous PR it closes #106, closes #102 , closes #89, closes #88, closes #69, closes #65 and closes #54
uber · May 6, 2020 · f525a37 · f525a37
2 parents f668808 + fee93bd
commit f525a37
Show file tree

Hide file tree

Showing 2 changed files with 77 additions and 233 deletions.
diff --git a/examples/LGT_Pyro_Example.ipynb b/examples/LGT_Pyro_Example.ipynb
diff --git a/orbit/pyro/lgt.py b/orbit/pyro/lgt.py
@@ -144,6 +144,9 @@ def __call__(self):
 
         lgt_sum = l + gt_coef * l.abs() ** gt_pow + lt_coef * b
         lgt_sum = torch.cat([l[..., :1], lgt_sum[..., :-1]], dim=-1)  # shift by 1
+        # a hack here as well to get rid of the extra "1" in r.shape
+        if r.dim() >= 2:
+            r = r.squeeze(-2)
         yhat = lgt_sum + s[..., :num_of_obs] + r
 
         with pyro.plate("response_plate", num_of_obs - 1):