Deprecating pyarrow_serialize argument of petastorm.make_reader.
#617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyarrow serialization is no longer suppoted. It actually has no merit as python3's pickle is faster then pyarrow serialization with numpy arrays.
selitvin
force-pushed
the
pyarrow2_compat
branch
from
da94f9a
to
84c24e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
==========================================
- Coverage 85.35% 85.31% -0.05%
==========================================
Files 86 85 -1
Lines 4951 4929 -22
Branches 785 783 -2
==========================================
- Hits 4226 4205 -21
+ Misses 585 584 -1
Partials 140 140
Continue to review full report at Codecov.
|
Ivan-Dimitrov
approved these changes
Nov 9, 2020
Comment on lines
+153
to
+154
| warnings.warn("pyarrow_serializer was deprecated and will be removed in future versions. " | ||
| "The argument no longer has any effect.") |
There was a problem hiding this comment.
Isn't it more accurate to say was deprecated and removed. The argument no longer has any effect..
S
There was a problem hiding this comment.
Strictly speaking we didn't remove it from the API. It does not have any effect anymore and that's mentioned in the message. If we would remove the argument, the existing code would break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyarrow serialization is no longer suppoted. It actually has no merit as python3's pickle is faster then pyarrow serialization with numpy arrays.