This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Add diff id to PostbuildSummary #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add diff id to Differential * Report diff id in post build summary * Correct unit test for revision id It would be nice to provide differential id in Differential class. The diff id is extracted from raw conduit json in the same way as revision id, although it is also available from Jenkins params DIFF_ID. Mean while, the differential test is updated to distinguish diff id from revision id.
liuhaotian
commented
Dec 28, 2016
| this.rawJSON = rawJSON; | ||
| } | ||
|
|
||
| public String getDIffID() { |
There was a problem hiding this comment.
Should it be public String getID() { instead?
There was a problem hiding this comment.
@jjx It may be inconsistent with the surrounding code like getRevisionID though.
jjx
approved these changes
Dec 28, 2016
| this.rawJSON = rawJSON; | ||
| } | ||
|
|
||
| public String getDIffID() { |
|
@jjx @sectioneight would you help me merge the pr? Github think I am not authorized to do so. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to provide differential id in Differential class. The
diff id is extracted from raw conduit json in the same way as revision
id, although it is also available from Jenkins params DIFF_ID.
Mean while, the differential test is updated to distinguish diff id
from revision id.