-
Notifications
You must be signed in to change notification settings - Fork 100
Added Requirement #201
Added Requirement #201
Conversation
Just to avoid uber-archive#190
|
readme.md
Outdated
Requirements | ||
============= | ||
|
||
* Arc available on Jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this a bit more descriptive:
* [Arcanist](https://github.com/phacility/arcanist) is installed on the Jenkins nodes where the tests will be run (e.g. not just the master) an the `arc` binary is in `$PATH` or configured explicitly in the global settings.
or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
readme.md
Outdated
Requirements | ||
============= | ||
|
||
* [Arcanist](https://github.com/phacility/arcanist) is installed on the Jenkins nodes where the tests will be run (e.g. not just the master) an the `arc` binary is in `$PATH` or configured explicitly in the global settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: and the ...
Also we should note that this is only required if you use the "Apply Phabricator Differential" part of the plugin. Some people just use the post-build action (e.g. to report data to harbormaster, which can be used either with staging areas or if you're running builds on diffusion commits). But we can clarify that later. For now just fix the typo then
Thanks!
Thanks! |
Just to avoid #190