Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Conversation

VeeeneX
Copy link
Contributor

@VeeeneX VeeeneX commented Jan 25, 2017

Just to avoid #190

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

readme.md Outdated
Requirements
=============

* Arc available on Jenkins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this a bit more descriptive:

* [Arcanist](https://github.com/phacility/arcanist) is installed on the Jenkins nodes where the tests will be run (e.g. not just the master) an the `arc` binary is in `$PATH` or configured explicitly in the global settings.

or something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.323% when pulling 39e2546 on VeeeneX:patch-1 into 69516ab on uber:master.

readme.md Outdated
Requirements
=============

* [Arcanist](https://github.com/phacility/arcanist) is installed on the Jenkins nodes where the tests will be run (e.g. not just the master) an the `arc` binary is in `$PATH` or configured explicitly in the global settings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: and the ...

Also we should note that this is only required if you use the "Apply Phabricator Differential" part of the plugin. Some people just use the post-build action (e.g. to report data to harbormaster, which can be used either with staging areas or if you're running builds on diffusion commits). But we can clarify that later. For now just fix the typo then :shipit:

Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.323% when pulling 39e2546 on VeeeneX:patch-1 into 69516ab on uber:master.

@ascandella ascandella merged commit 65de8c0 into uber-archive:master Jan 25, 2017
@ascandella
Copy link
Contributor

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants