This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Update build url #271
Merged
Update build url #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Aug 16, 2018
ghost
commented
- Add an additional global configuration item to indicate that we want to generate blue ocean URI's in comments posted back to Phabricator
- Update the logic that generates the build URL to use a different environment variable (exposed by blue ocean plugins) assuming we want to generate blue ocean URI's - otherwise leave it as it was
- Fixes: Update comments to Blueocean URI's #269
- Add an additional global configuration item to indicate that we want to generate blue ocean URI's in comments posted back to Phabricator - Update the logic that generates the build URL to use a different environment variable (exposed by blue ocean plugins) assuming we want to generate blue ocean URI's - otherwise leave it as it was
|
|
|
Only a minor change but tested on our local Jenkins & phabricator instance and it works as expected: |
ChaitanyaPramod
suggested changes
Sep 10, 2018
| uberallsURL = value; | ||
| } | ||
|
|
||
| public boolean getBlueOceanURI() { |
There was a problem hiding this comment.
The methods and field make it appear like the property is a URI and not a boolean. Please change the property name
- Update names of variables to make it more obvious that this is boolean config
|
@ChaitanyaPramod Pull request updated with new variable names - why is naming stuff always the hardest thing :) |
ChaitanyaPramod
approved these changes
Sep 10, 2018
kageiit
approved these changes
Sep 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.