Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Fix NullPointerExceptions with Pipeline. (#296) #312

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Fix NullPointerExceptions with Pipeline. (#296) #312

merged 1 commit into from
Dec 17, 2018

Conversation

na-Itms
Copy link
Contributor

@na-Itms na-Itms commented Dec 17, 2018

  • Fix the CommentBuilder by passing a build result that is correctly sanitized by the BuildResultProcessor.
  • Sanitize for non-differential builds as well.

@na-Itms
Fix NullPointerExceptions with Pipeline. (uber-archive#296)
16489a6 
* Fix the CommentBuilder by passing a build result that is correctly sanitized by the BuildResultProcessor.
* Sanitize for non-differential builds as well.
@na-Itms na-Itms mentioned this pull request Dec 17, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 90.063% when pulling 16489a6 on na-Itms:comment-build-result-fix into fd92537 on uber:master.

@kageiit kageiit merged commit d0bdd17 into uber-archive:master Dec 17, 2018
@AttwellBrian AttwellBrian mentioned this pull request Feb 20, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@kageiit kageiit kageiit approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@na-Itms @coveralls @kageiit